Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the rabbitmq group to 999 and add bash which is required for t… #203

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Switch the rabbitmq group to 999 and add bash which is required for t… #203

merged 1 commit into from
Jan 9, 2023

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jan 9, 2023

…he entrypoint.

Signed-off-by: Dan Lorenc dlorenc@chainguard.dev

@dlorenc dlorenc requested a review from a team as a code owner January 9, 2023 19:40
@dlorenc dlorenc requested review from kaniini and removed request for a team January 9, 2023 19:40
@amouat
Copy link
Contributor

amouat commented Jan 9, 2023

@dlorenc just to be clear, rabbitmq expects the user to be uid 999?

@jdolitsky
Copy link
Contributor

needs rebase:

The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.

@dlorenc
Switch the rabbitmq group to 999 and add bash which is required for t…
e039601 
…he entrypoint.

Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
@jdolitsky jdolitsky mentioned this pull request Jan 9, 2023
Closed
@dlorenc
Copy link
Contributor Author

dlorenc commented Jan 9, 2023

@dlorenc just to be clear, rabbitmq expects the user to be uid 999?

The rabbitmq operator, which is the primary method of installing rabbitmq in clusters seems to have that expectation :(

@dlorenc dlorenc merged commit 14f3657 into chainguard-images:main Jan 9, 2023
@dlorenc dlorenc deleted the finalrab branch January 9, 2023 19:49
@k4leung4
Copy link
Contributor

k4leung4 commented Jan 9, 2023

@dlorenc just to be clear, rabbitmq expects the user to be uid 999?

The rabbitmq operator, which is the primary method of installing rabbitmq in clusters seems to have that expectation :(

for reference:
https://github.com/rabbitmq/cluster-operator/blob/878dc7cc2e6296738c4a97eddd861b81bc15404f/internal/resource/statefulset.go#L537

There is more discussion around the user that should be used, and this may need more changes when we test this image on openshift, docker-library/rabbitmq#529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@kaniini kaniini Awaiting requested review from kaniini kaniini was automatically assigned from chainguard-images/images-repository-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlorenc @amouat @jdolitsky @k4leung4